Reactions to chat messages

[mahibi]

resolve #1772

Message	Reactions menu	Reactions listing

remaining TODOs:

• send reaction
  • emoji picker
• delete reaction
• tab layout
  • add view pager if time permits
• show reactions for all MessageViewHolders (incoming + outgoing messages)
  • TextMessages
  • VoiceMessages
  • Location
  • Previews
• set textcolor for reaction for outgoing messages
• sort emojis in message view descending by amount
• analyze why some emojis are not shown some emojis are not shown  #1913
  • 
• sort reaction list
  • own user to the top - see sorting rule at Reactions to chat messages #1772 (comment)
    • regarding the "all" view, first rule should better be the amount of reaction? @AndyScherzinger

known issues:

• emoji picker sometimes opens in full screen height #1914
  • emoji picker SOMETIMES (but unfortunately most of the times on first usage) opens in full screen height. see Popup takes up full screen when in adjustPan mode vanniktech/Emoji#474
  • 

[AndyScherzinger]

@mahibi changinging the sorting for the all tab can be done but shouldn't block this PR - can't say if/when I find the time or you can give it a go.

[XueSheng-GIT]

I downloaded the apk to test the reactions. Adding a reaction only works if there's no reaction yet (reaction menu pops up). But as soon as a reaction exists (from myself or another person), the reaction listing is shown (which doesn't seem to allow to add additional reactions...). I couldn't find a way to add a reaction in this case.
How to switch from the reaction listing to the reaction menu?

[mahibi]

I downloaded the apk to test the reactions. Adding a reaction only works if there's no reaction yet (reaction menu pops up). But as soon as a reaction exists (from myself or another person), the reaction listing is shown (which doesn't seem to allow to add additional reactions...). I couldn't find a way to add a reaction in this case. How to switch from the reaction listing to the reaction menu?

a long click on the message will open the Reactions menu where you can set an emoji. to set more emojis just do this another time. This should work regardless if there are already emojis or not!

if reactions exist, you can tap on them inside the message bubble to see details in the Reactions listing. In this view you can't add reactions but just view them (or delete your own reactions when you tap on them.)

Does this answer your question? Or is there some bug?

[XueSheng-GIT]

a long click on the message will open the Reactions menu where you can set an emoji. to set more emojis just do this another time. This should work regardless if there are already emojis or not!

For me this only works if there's no reaction yet. Long press on an existing reaction does nothing (while pressing). But when releasing the finger, the reaction listing appears.

UPDATE: Just realized that long press works if you exactly hit the text iself. Long press on existing reactions does not open the reactions menu. A bit confusing and not obvious.

[mahibi]

a long click on the message will open the Reactions menu where you can set an emoji. to set more emojis just do this another time. This should work regardless if there are already emojis or not!

For me this only works if there's no reaction yet. Long press on an existing reaction does nothing (while pressing). But when releasing the finger, the reaction listing appears.

if there are emojis in the message, there's a difference if you tap on the message text or the emojis themselves.
so a long press on the message text will open the Reactions menu.
a press on the emojis will open the Reactions listing view.

does this work for you?

But maybe it should be changed that a long tap on the emojis should also open the Reactions menu....

[AndyScherzinger]

But maybe it should be changed that a long tap on the emojis should also open the Reactions menu....

for long press, I'd say yes because that would be the expected result I believe.

[mahibi]

UPDATE: Just realized that long press works if you exactly hit the text iself. Long press on existing reactions does not open the reactions menu. A bit confusing and not obvious.

just changed this. that was a good hint, thanks for testing @XueSheng-GIT 👍

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	164	156
Errors	1	1

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	9
Correctness Warnings	91
Experimental Warnings	2
Internationalization Warnings	9
Malicious code vulnerability Warnings	115
Performance Warnings	27
Security Warnings	2
Dodgy code Warnings	158
Total	413

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	9
Correctness Warnings	91
Experimental Warnings	2
Internationalization Warnings	9
Malicious code vulnerability Warnings	115
Performance Warnings	27
Security Warnings	2
Dodgy code Warnings	158
Total	413

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1895-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[mahibi]

merged without approval to get towards the next RC (tonight or in the next days i guess).

thanks for your help @AndyScherzinger 👍

[AndyScherzinger]

My pleasure 😊