Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of com.nextcloud.ui.popupbubble.PopupBubble #4391

Open
mahibi opened this issue Oct 29, 2024 · 0 comments · May be fixed by #4474
Open

get rid of com.nextcloud.ui.popupbubble.PopupBubble #4391

mahibi opened this issue Oct 29, 2024 · 0 comments · May be fixed by #4474
Assignees
@sowjanyakch
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request

Comments

@mahibi
Copy link
Collaborator

mahibi commented Oct 29, 2024

In PR #4390 (commit f4340f3)

the com.nextcloud.ui.popupbubble.PopupBubble (forekd from https://github.com/webianks/PopupBubble)

was removed to show the unread messages button.

It is still used in ConversationsListActivity. It should be replaced so we can get rid of it (it's very outdated)
@mahibi mahibi added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request labels Oct 29, 2024
@sowjanyakch sowjanyakch linked a pull request Nov 21, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sowjanyakch sowjanyakch

Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Popup bubble with Material Button nextcloud/talk-android
2 participants
@mahibi @sowjanyakch