-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Popup bubble with Material Button #4474
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4474-talk.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the behavior of the button is now different for me. When clicked, the list will scroll as expected but the button won't disappear.
Only after a pull to refresh it seems to work that the button disappears for the next time it's clicked..
please remove the dependency of the popup bubble |
Resolve #4391
🚧 TODO
🏁 Checklist
/backport to stable-xx.x