Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch any error that may occur during row import #882

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 29, 2024

Small additional fix for importing, best to be reviewed as https://github.com/nextcloud/tables/pull/882/files?w=1

  • Catch any throwable during a specific row import as there is no reason we should just generally fail on the import if only one row causes issues
  • Skip rows that have no content at all

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Feb 29, 2024
@juliusknorr juliusknorr merged commit 0b5575c into main Feb 29, 2024
50 checks passed
@juliusknorr juliusknorr deleted the bugfix/import-catch branch February 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants