-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use simple input field instead of multiselect for plain URLs #787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the failing Cypress tests. Pushed a commit for this
ab9aab4
to
46b9850
Compare
Weird that the test still fails on some stable branches 🤔 |
How to reproduce this? I removed the provider stuff directly on db side like Thoughts:
|
Sorry I should have described this a bit more. The goal of this PR is purely to make the input more user friendly if only URL is enabled as a provider for a column, as in this case the multiselect does not give any benefit as there is only one option to select (which is inserting the plain URL). I agree we should still fetch the title and store/render it for additional context. Will look into that. |
46b9850
to
7874c1f
Compare
@juliushaertl Do we still need this? |
Yes, I think this would still be a nice improvement. Will try to wrap it up |
Signed-off-by: Julius Härtl <[email protected]>
7874c1f
to
18b5344
Compare
Ok that has been a while 🙈 Finally pushed some more adjustments here all summarized with a screen recording in the first post. |
Signed-off-by: Cleopatra Enjeck M <[email protected]>
18b5344
to
f5eb414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…elect Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
6f199e2
to
ef6ea7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 😎 👍
When no link provider (except URL) is enabled a multiselect field might be confusing to users, so this PR switches over to a simple input field in that case. As there are no suggestions then a multiselect does not make sense.
Styling of the multiselect is still a bit odd, but will check that separately as it seems to come from the component library.
Kapture.2024-08-22.at.15.54.06.webm