Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create appstore-build-publish.yml #783

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Create appstore-build-publish.yml #783

merged 1 commit into from
Jan 19, 2024

Conversation

juliusknorr
Copy link
Member

For building releases in the github action

@juliusknorr juliusknorr added the 3. to review Waiting for reviews label Jan 19, 2024
Comment on lines +1 to +4
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here is just an exact copy of what's at the template repo. I expected some lines will be changed to make the template suitable for Tables specifically? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template can handle any app uses our common build tooling, so no adjustment needed. I can walk you through how that works when building the first release with it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's pretty cool, thanks

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@juliusknorr juliusknorr merged commit 5248beb into main Jan 19, 2024
40 checks passed
@juliusknorr juliusknorr deleted the juliushaertl-patch-1 branch January 19, 2024 08:13
@juliusknorr
Copy link
Member Author

/backport to stable0.6

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 23, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants