feat: transfer ownership via webgui #741

enjeck · 2023-12-14T05:27:18Z

This addresses #711
The goal is to add a way to transfer table ownershi using the webgui

enjeck · 2023-12-14T05:27:43Z

I forgot to sign my commit messages. Can ammend that later

enjeck

I do not yet understand how the backend and frontend connect to each other. I plan to spend more time on more tutorials to understand this. Since the associated issue for this was marked as a "good first issue", I thought I could easily handle this after following the introductory tutorial but I couldn't. So it's either I'm overcomplicating this and there's an easier way to go about it, or it's more complex than it seems. Would appreciate hints on what's the right direction to follow

appinfo/routes.php

lib/Controller/Api1Controller.php

src/modules/sidebar/partials/TransferForm.vue

src/store/store.js

datenangebot · 2023-12-14T06:55:47Z

I'm still very confused about what the UI should look like

The "edit table" modal was meant, that one is not crowded?!
Cloud look like this:

And if you click on the "change owner" button, your modal gets opened.

Btw: I guess the word "share" is not correct here, we have sharing option elsewhere for real sharing.

enjeck · 2023-12-14T07:03:09Z

I'm still very confused about what the UI should look like

The "edit table" modal was meant, that one is not crowded?! Cloud look like this:

And if you click on the "change owner" button, your modal gets opened.

Btw: I guess the word "share" is not correct here, we have sharing option elsewhere for real sharing.

@datenangebot Ah, I see what you mean. Makes sense. Should have asked clarified earlier. Thanks

datenangebot · 2023-12-14T10:04:21Z

As a reminder for us, please make sure that we have this before merging:

CI is green
integration tests
end2end test
ensure that only allowed user can change ownership of tables

src/modules/modals/TransferTable.vue

juliusknorr

Thanks @enjeck. I left a few inline comments regarding smaller code suggestions, but apart from that this looks quite nice already and works well :)

cypress/e2e/tables-table.cy.js

src/modules/modals/TransferTable.vue

src/shared/components/ncTable/mixins/permissionsMixin.js

src/shared/components/ncUserAndGroupPicker/NcUserAndGroupPicker.vue

juliusknorr · 2023-12-27T14:36:06Z

Regarding the CI failure, you might want to check the details at https://github.com/nextcloud/tables/pull/741/checks?check_run_id=19976327121 on how to solve it and make sure to signoff commits in the future:

enjeck · 2023-12-27T17:00:36Z

Regarding the CI failure, you might want to check the details at https://github.com/nextcloud/tables/pull/741/checks?check_run_id=19976327121 on how to solve it and make sure to signoff commits in the future:

For some reason, trying to sign from VS Code doesn't work. I thought I set this up already, but apparently not :/. I'll try again

github-actions · 2023-12-29T02:01:19Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

src/shared/components/ncUserAndGroupPicker/NcUserAndGroupPicker.vue

datenangebot · 2024-01-11T07:49:30Z

@enjeck Hey, do you want to rebase, force push and merge into main here? I mean feature seems to be good, CI is green and this PR is approved... 😁

juliusknorr · 2024-01-11T10:40:55Z

Could you rebase instead of adding a merge commit? Let me know if you need some guidance on that :)

Signed-off-by: Cleopatra Enjeck M <[email protected]>

Signed-off-by: Florian Steffens <[email protected]>

- add suggestion for UI - move user lookup to a shared component as it could be used elsewhere - logic to request users and groups is missing, should be exchanged with new api endpoint Signed-off-by: Florian Steffens <[email protected]>

- make use of API v2 structure - add route - add controller method and API description - update API docs Signed-off-by: Florian Steffens <[email protected]>

- reuse and adjust from occ command - adjust occ command logic to fit to the new business - adjust permission service to allow those changes Signed-off-by: Florian Steffens <[email protected]>

Signed-off-by: Florian Steffens <[email protected]>

Signed-off-by: Cleopatra Enjeck M <[email protected]>

enjeck commented Dec 14, 2023

View reviewed changes

appinfo/routes.php Outdated Show resolved Hide resolved

lib/Controller/Api1Controller.php Outdated Show resolved Hide resolved

src/modules/sidebar/partials/TransferForm.vue Outdated Show resolved Hide resolved

enjeck commented Dec 14, 2023

View reviewed changes

src/store/store.js Outdated Show resolved Hide resolved

enjeck requested a review from datenangebot December 14, 2023 06:03

datenangebot force-pushed the feature/711 branch from 91bdeae to 2b828b9 Compare December 14, 2023 10:00

juliusknorr added enhancement New feature or request 2. developing Work in progress labels Dec 18, 2023

enjeck commented Dec 26, 2023

View reviewed changes

src/modules/modals/TransferTable.vue Outdated Show resolved Hide resolved

src/modules/modals/TransferTable.vue Outdated Show resolved Hide resolved

enjeck requested a review from juliusknorr December 26, 2023 08:25

enjeck force-pushed the feature/711 branch 2 times, most recently from 59be853 to 720c8be Compare December 27, 2023 08:44

enjeck marked this pull request as ready for review December 27, 2023 08:45

enjeck changed the title ~~(WIP) feat: transfer ownership via webgui~~ feat: transfer ownership via webgui Dec 27, 2023

enjeck commented Dec 27, 2023

View reviewed changes

src/modules/modals/TransferTable.vue Show resolved Hide resolved

juliusknorr requested changes Dec 27, 2023

View reviewed changes

juliusknorr linked an issue Dec 28, 2023 that may be closed by this pull request

transfer ownership via webgui #711

Closed

github-actions bot added the feedback-requested label Dec 29, 2023

enjeck force-pushed the feature/711 branch from 720c8be to 4d7ab2a Compare December 29, 2023 08:52

enjeck commented Dec 29, 2023

View reviewed changes

src/shared/components/ncUserAndGroupPicker/NcUserAndGroupPicker.vue Outdated Show resolved Hide resolved

enjeck commented Dec 29, 2023

View reviewed changes

src/shared/components/ncUserAndGroupPicker/NcUserAndGroupPicker.vue Outdated Show resolved Hide resolved

juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 4, 2024

juliusknorr self-requested a review January 4, 2024 09:34

juliusknorr approved these changes Jan 5, 2024

View reviewed changes

enjeck and others added 14 commits January 11, 2024 13:06

feat: transfer table ownership backend

5777333

Signed-off-by: Cleopatra Enjeck M <[email protected]>

feat: transfer table ownership frontend

e422055

Signed-off-by: Cleopatra Enjeck M <[email protected]>

Fix unrelated bugs and update dependencies

11b50d6

Signed-off-by: Florian Steffens <[email protected]>

Cleanup and restructure vue components

0e33075

- add suggestion for UI - move user lookup to a shared component as it could be used elsewhere - logic to request users and groups is missing, should be exchanged with new api endpoint Signed-off-by: Florian Steffens <[email protected]>

Setup new API endpoint to change ownership of a table

4095a82

- make use of API v2 structure - add route - add controller method and API description - update API docs Signed-off-by: Florian Steffens <[email protected]>

Adjust business logic to change tables ownership

96f0c56

- reuse and adjust from occ command - adjust occ command logic to fit to the new business - adjust permission service to allow those changes Signed-off-by: Florian Steffens <[email protected]>

add integration test for new API endpoint

b5484a4

Signed-off-by: Florian Steffens <[email protected]>

Adjust logic and UI to change tables ownership

785c110

Signed-off-by: Cleopatra Enjeck M <[email protected]>

Add Cypress tests for table transfer

5db1681

Signed-off-by: Cleopatra Enjeck M <[email protected]>

clean up

739d14f

Signed-off-by: Cleopatra Enjeck M <[email protected]>

Fix lint

199e50e

Signed-off-by: Cleopatra Enjeck M <[email protected]>

style: separate placeholder strings

a2b6535

Signed-off-by: Cleopatra Enjeck M <[email protected]>

ci: fix lint

8ed3ee5

Signed-off-by: Cleopatra Enjeck M <[email protected]>

fix: change search url

f0e446f

Signed-off-by: Cleopatra Enjeck M <[email protected]>

enjeck force-pushed the feature/711 branch from 591338d to f0e446f Compare January 11, 2024 12:38

enjeck merged commit 173534d into main Jan 11, 2024
43 checks passed

enjeck deleted the feature/711 branch January 11, 2024 14:03

juliusknorr assigned enjeck Jan 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: transfer ownership via webgui #741

feat: transfer ownership via webgui #741

enjeck commented Dec 14, 2023

enjeck commented Dec 14, 2023

enjeck left a comment •

edited

Loading

datenangebot commented Dec 14, 2023

enjeck commented Dec 14, 2023 •

edited

Loading

datenangebot commented Dec 14, 2023 •

edited by enjeck

Loading

juliusknorr left a comment

juliusknorr commented Dec 27, 2023

enjeck commented Dec 27, 2023

github-actions bot commented Dec 29, 2023

datenangebot commented Jan 11, 2024

juliusknorr commented Jan 11, 2024 •

edited

Loading

feat: transfer ownership via webgui #741

feat: transfer ownership via webgui #741

Conversation

enjeck commented Dec 14, 2023

enjeck commented Dec 14, 2023

enjeck left a comment • edited Loading

Choose a reason for hiding this comment

datenangebot commented Dec 14, 2023

enjeck commented Dec 14, 2023 • edited Loading

datenangebot commented Dec 14, 2023 • edited by enjeck Loading

juliusknorr left a comment

Choose a reason for hiding this comment

juliusknorr commented Dec 27, 2023

enjeck commented Dec 27, 2023

github-actions bot commented Dec 29, 2023

datenangebot commented Jan 11, 2024

juliusknorr commented Jan 11, 2024 • edited Loading

enjeck left a comment •

edited

Loading

enjeck commented Dec 14, 2023 •

edited

Loading

datenangebot commented Dec 14, 2023 •

edited by enjeck

Loading

juliusknorr commented Jan 11, 2024 •

edited

Loading