Feat(Views): Manage data presentation of tables by views

[Hephi2]

Views are tables that contain and display certain data of the underlying data table. Views allow you to select the columns to display and their order, filter and sort the rows. Combined with functions such as sharing with specific permissions and more, this enables the creation of workflows.

View related

• Resolves Create views for tables #12
• Resolves Persistence of filtering, sorting and pagination values #63
• Resolves show meta columns #197
• Resolves Share views #310
• Resolves Views: Menu reordering #387
• Resolves View: Add consistent sorting  #388
• Resolves View: Create view from currently selected filters and sorting #389
• Resolves View: Add possibility to clone view #391
• Resolves View: Create column in view #392
• Resolves View: Use basis views instead of tables #393
• Resolves View: Refactor column menu #394
• Resolves View: Refactor edit column functionality #395
• Resolves View: Create row #397
• Resolves View: Remove current frontend sorting #398
• Resolves View: Fix import functionality with views #407
• Resolves Views: Revise permissions for sharing #408
• Resolves View: Permission handling #412
• Resolves Unauthorised access on shared views due to out-of-date data #414
• Resolves View: Design Improvements #419
• Resolves Shares may be listed multiple times #420
• Resolves Views: Migration of existing data #423
• Resolves Proper logging of exceptions #422
• Resolves Table overview design polishing #450

Unrelated but still solved

• Resolves Incorrect order of the table columns after reordering #343
• Resolves Column filters are case-sensitive #424
• Resolves Provide better Column Sorting incl. Interface #230 ?
• Resolves Move column order in "edit columns" is fuzzy #108

[juliusknorr]

Some early comments on the first batch of files I went over. Overall this looks super nice already :)

[juliusknorr]

Not sure if we may need to keep a compatibility endpoint (for this and other dropped ones) to just point to the base view then, as I know @stefan-niedermann is already using this API for an Android client in the works ;)

[stefan-niedermann]

@juliushaertl if you can give me a list of dropped endpoints I can tell you which one are problematic for the Tables Android App 🙂

[stefan-niedermann]

APIs used by the Tables Android App 1.1.2:

GET    /tables
POST   /tables
DELETE /tables/{tableId}
PUT    /tables/{tableId}
GET    /tables/{tableId}/columns
POST   /tables/{tableId}/columns
PUT    /columns/{columnId}
DELETE /columns/{columnId}
GET    /tables/{tableId}/rows    <-- Dropped?
POST   /tables/{tableId}/rows
PUT    /rows/{rowId}
DELETE /rows/{rowId}

If one of them needs to get dropped, it would be awesome to maintain backward compatibility for at least one major version of the Tables server app while announcing deprecations for the APIs that shall be dropped, so 3rd party users have some time to adapt the changes.

Looking forward to a list of APIs that will be dropped and which replacements will be there 🙂

[stefan-niedermann]

@juliushaertl / @datenangebot ping 🙂

[stefan-niedermann]

Given the PR has been merged, I assume that there are breaking changes in the API? Are the differences documented or announced somewhere?

@juliushaertl @datenangebot

[datenangebot]

Hi, all routes are back and should work as before, no breaking changes.
(Some new routes are not yet documented: #452)

[juliusknorr]

Might be personal preference but I feel something like this would be easier to read and saves the extra else branch:

Suggested change

	if ($keyword) {
	return $this->handleError(function () use ($keyword, $limit, $offset) {
	return $this->viewService->search($keyword, $limit, $offset);
	});
	} else {
	return $this->handleError(function () use ($tableId) {
	return $this->viewService->findAll($this->tableService->find($tableId));
	});
	}
	return $this->handleError(function () use ($keyword, $limit, $offset) use (keyword, $limit, $offset) {
	if ($keyword !== null) {
	return $this->viewService->search($keyword, $limit, $offset);
	}
	return $this->viewService->findAll($this->tableService->find($tableId));
	});

Null check would also be safer to do a strict comparison as it allows to use the limit/offset with an empty search term. In gerneral findAll and search could probably be combined in one method.

[juliusknorr]

Actually looking at it again, i find it odd that search ignores the tableId

[juliusknorr]

We should carefully review the queries at some point and see where it would make sense to add indices to the tables

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

[kesselb]

Great job, thank you 👍

[kesselb]

Please add another constant for Oracle DB, usually called oci in our code.

Currently, because MySQL is the else in formatCellValue, it would use the MySQL dialect, which is not going to work 😞

[datenangebot]

Oracle is not yet supported. No plans for it yet.
Install shouln't be possible on oci db backends...

[kesselb]

Lucky you 😃

[datenangebot]

Great changes, need some refactorings later on, but fine for now.