Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share with teams #1465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

share with teams #1465

wants to merge 1 commit into from

Conversation

hweihwang
Copy link
Contributor

@hweihwang hweihwang commented Nov 18, 2024 •
edited by juliusknorr
Loading

Fixes #142

@hweihwang hweihwang force-pushed the share-with-teams branch 5 times, most recently from 8a288e5 to a6da886 Compare November 18, 2024 10:12
@juliusknorr juliusknorr added enhancement New feature or request 2. developing Work in progress labels Nov 18, 2024
@hweihwang hweihwang linked an issue Nov 18, 2024 that may be closed by this pull request
Share with Teams #142
Open
blizzz
blizzz requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the backend bits only so far.

lib/Helper/CircleHelper.php Outdated Show resolved Hide resolved
lib/Helper/CircleHelper.php Outdated Show resolved Hide resolved
lib/Helper/UserHelper.php Outdated Show resolved Hide resolved
lib/Service/ShareService.php Show resolved Hide resolved
@hweihwang
Copy link
Contributor Author

Thanks Arthur @blizzz 🙏 - those are really helpful!

@hweihwang hweihwang force-pushed the share-with-teams branch 2 times, most recently from 93927cb to a36c56e Compare November 20, 2024 10:21
@hweihwang hweihwang marked this pull request as ready for review November 20, 2024 10:22
@hweihwang hweihwang force-pushed the share-with-teams branch 5 times, most recently from fcf2c54 to 7803db6 Compare November 22, 2024 06:54
@hweihwang
share with teams
34d53d6 
Signed-off-by: Hoang Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share with Teams
3 participants
@hweihwang @blizzz @juliusknorr