-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Contexts): enable nav bar display logic #1193
base: main
Are you sure you want to change the base?
Conversation
2a6a88f
to
52638ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend change looks good 👍
52638ee
to
ac42f69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me block the merge just to be sure this doesn't get lost from the initial post
Yeah, I'm looking into the frontend parts :D |
Great, thanks :) |
It seems there's no way for an owner to modify their navigation entry if there are no shares? Creating an application without shares means there's no navigation entry, and no way to change it. @blizzz |
This is accurate. We bound the nav bar display state to sharing. Also the share id is part of the primary key. I do see it is reasonable to have this setting for non-shared applications, but spontaneously a quick solution that is not too terrible does not come to my mind. Is it a blocker? |
Maybe not a blocker, but still inconvenient and not very user-friendly. The UI right now doesn't look great, and I can't seem to fix it due to this: #1295 |
Yup, I am with you there. Need to think about a good strategy. |
ac42f69
to
ccf873b
Compare
ccf873b
to
8075a22
Compare
0edd48a
to
cd00c05
Compare
It was temporarily disabled and shown by default as we did not have web UI controls to configure it. Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
cd00c05
to
bc6ae95
Compare
@enjeck I feel a bit disconnected. That toggle there, changing it does not have any effect via GUI. |
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
contributes to #1177
It was temporarily disabled and shown by default as we did not have web UI controls to configure it.