Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migration): Decrypt ownCloud secrets v2 #49523

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(migration): Decrypt ownCloud secrets v2 #49523

merged 1 commit into from
Nov 28, 2024

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 27, 2024 •
edited
Loading

  • Resolves: #

Summary

owncloud/core#38018 and #20915 are slightly different. This teaches Nextcloud to read encrypted values from a migrated instance.

TODO

  • Do
  • Conventional commit ())

Checklist

@ChristophWurst ChristophWurst changed the title fix(migration: Decrypt ownCloud secrets v2 fix(migration): Decrypt ownCloud secrets v2 Nov 27, 2024
miaulalala
miaulalala approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🦙

AndyScherzinger
AndyScherzinger approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neighborly 👍

@ChristophWurst ChristophWurst force-pushed the fix/migration/owncloud-secrets-v2 branch from 3174cc5 to 8eb71f1 Compare November 28, 2024 07:38
@ChristophWurst
Copy link
Member Author

/backport to stable30

@ChristophWurst
Copy link
Member Author

/backport to stable29

@ChristophWurst
Copy link
Member Author

/backport to stable28

nickvergessen
nickvergessen reviewed Nov 28, 2024
View reviewed changes
lib/private/Security/Crypto.php Outdated Show resolved Hide resolved
lib/private/Security/Crypto.php Outdated Show resolved Hide resolved
lib/private/Security/Crypto.php Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst force-pushed the fix/migration/owncloud-secrets-v2 branch from d5b2ba0 to 1323e5b Compare November 28, 2024 08:00
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2024
@nickvergessen nickvergessen merged commit a9c36c1 into master Nov 28, 2024
187 checks passed
@nickvergessen nickvergessen deleted the fix/migration/owncloud-secrets-v2 branch November 28, 2024 08:17
This was referenced Nov 28, 2024
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@Altahrim Altahrim Altahrim approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: owncloud migration
Projects
💌 📅 👥 Groupware team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @nickvergessen @AndyScherzinger @Altahrim @miaulalala