Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SetupChecks): Pass webfinger if the handler returns 400 too #49440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Nov 21, 2024

Summary

When running a check against /.well-known/webfinger in a stock install the checks are fine, but when an actual webfinger handler is installed (like the social app) the return code is going to be 400 per the spec1 since the setup check isn't providing a ?resource value (and we're not going to).

Semi-related: nextcloud/social#1951 (because we were returning a 500 error since our check doesn't pass a resource value and now once merged that'll return a 400 as per the spec; though our checks obviously wouldn't have passed either way).

TODO

  • ...

Checklist

Footnotes

  1. https://datatracker.ietf.org/doc/html/rfc7033#section-4.2

@joshtrichards
Copy link
Member Author

/backport to stable30

@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards joshtrichards changed the title fix(SetupChecks): Pass webfinger if a handler (e.g. social) is enabled fix(SetupChecks): Pass webfinger if the handler returns 400 Nov 23, 2024
@joshtrichards joshtrichards changed the title fix(SetupChecks): Pass webfinger if the handler returns 400 fix(SetupChecks): Pass webfinger if the handler returns 400 too Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant