fix(settings): Provide visual feedback 4 encryption toggle #49200
Conversation
nfebe
force-pushed
the
fix/48829/visual-feedback-4-encryption-toggle
branch
from
35222b8
to
2a2f629
Compare
nfebe
added
enhancement
3. to review
nfebe
force-pushed
the
fix/48829/visual-feedback-4-encryption-toggle
branch
from
2731f3d
to
016738f
Compare
That is one option, I am just did this around the feedback from a user.... cc: @marcoambrosini @jancborchardt Plus that has the limitation that we have to display the warning at all times somewhere on the page as disabled components do not respond to events. |
I think this is the way to go @nfebe -- |
|
This means we would display the warning around (ontop, beside, under) the toggle? cc; @marcoambrosini |
|
Usually we place warning text underneath the inputs. We have this built into the password input component for example. Maybe it would even make sense to include this in the component? @skjnldsv wdyt? |
`Object.entries([])` would return an empty array, that leads to the `find` return undefined. `encryptionReady` and `encryptionEnabled` also returns undefined when no encryption module is available or functional (I guess). Signed-off-by: nfebe <[email protected]>
Show visual feedback if user clicks on encryption toggle when it cannot be activated. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/48829/visual-feedback-4-encryption-toggle
branch
from
016738f
to
61bac10
Compare
Show visual feedback if user clicks on encryption toggle when it cannot be activated.
Demo
feedback-no-encryption-module.webm
Other improvement
Object.entries([])would return an empty array, that leads to thefindencryptionReadyandencryptionEnabledalso returns undefined when no encryption module is available or functional (I guess).Resolves : #48829