Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add PasswordConfirmationRequired to saveGlobalCredentials #48992

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: add PasswordConfirmationRequired to saveGlobalCredentials #48992

merged 1 commit into from
Oct 30, 2024
+19 −10

Conversation

yemkareems
Copy link
Contributor

fix: add PasswordConfirmationRequired to saveGlobalCredentials

  • Resolves: #

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems self-assigned this Oct 30, 2024
@yemkareems yemkareems added 2. developing Work in progress 3. to review Waiting for reviews labels Oct 30, 2024
@yemkareems @susnux
fix: add PasswordConfirmationRequired to saveGlobalCredentials
3b6a36f 
Co-authored-by: yemkareems <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/add-password-confirmation-to-save-global-creds branch from e7fd526 to 3b6a36f Compare October 30, 2024 09:55
@susnux susnux marked this pull request as ready for review October 30, 2024 09:55
@yemkareems yemkareems added backport-request and removed 2. developing Work in progress labels Oct 30, 2024
@yemkareems
Copy link
Contributor Author

/backport to stable27

@yemkareems
Copy link
Contributor Author

/backport to stable28

@yemkareems
Copy link
Contributor Author

/backport to stable29

@yemkareems
Copy link
Contributor Author

/backport to stable30

@yemkareems yemkareems merged commit 399b048 into master Oct 30, 2024
181 of 183 checks passed
@yemkareems yemkareems deleted the fix/add-password-confirmation-to-save-global-creds branch October 30, 2024 11:35
This was referenced Oct 30, 2024
Merged
Merged
Merged
Merged
@solracsf
Copy link
Member

Seems to be broken: #49349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@susnux susnux susnux approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@yemkareems yemkareems

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yemkareems @solracsf @susnux @provokateurin