-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Correctly copy the cache information during copy operations #48651
Conversation
9411fc1
to
eb3c214
Compare
This might help with #48174. |
eb3c214
to
b5fbe77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of 🐘 , I do not understand what’s going on here
b5fbe77
to
6a0e117
Compare
Snap, the server/lib/private/Files/ObjectStore/ObjectStoreStorage.php Lines 699 to 700 in 6a0e117
Edit: maybe this part can be improved: server/lib/private/Files/Cache/Updater.php Lines 203 to 206 in 6a0e117
|
f45c8ed
to
d050233
Compare
2bde182
to
fd0ef41
Compare
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder. Signed-off-by: Louis Chemineau <[email protected]>
fd0ef41
to
199b0bd
Compare
Signed-off-by: Louis Chemineau <[email protected]>
This introduced a regression for some cross-storage moves, see #49695 |
Needed to copy the
encrypted
flag of encrypted files when those files are two level down in a moved folder.Reproduction steps of the issue:
/A/B/t.txt
/C
A
inC
t.txt
is encrypted but does not have theencrypted
flag set totrue
, and therefore not readable.With this PR,
t.txt
is readable.Note: Open to better ways to share code between the two methods.
Added a test to ensure file content stays the same after a copy.