Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(talk_app): Simplify reference resolving logic #2616

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

provokateurin
Copy link
Member

Fixes #2598

I tried to be a bit too fancy and this ended in concurrent modification of the data in the behaviorsubject. This logic is a lot simpler and works as expected.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.85%. Comparing base (0efa671) to head (33d8b7a).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2616      +/-   ##
==========================================
- Coverage   28.86%   28.85%   -0.01%     
==========================================
  Files         370      370              
  Lines      136530   136521       -9     
==========================================
- Hits        39403    39394       -9     
  Misses      97127    97127              
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 0efa671
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 0efa671
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 0efa671
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 0efa671
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 0efa671
neon_dashboard 96.05% <ø> (ø) Carriedforward from 0efa671
neon_framework 61.33% <ø> (ø)
neon_http_client 97.45% <ø> (-0.05%) ⬇️ Carriedforward from 0efa671
neon_notifications 100.00% <ø> (ø) Carriedforward from 0efa671
neon_storage 94.66% <ø> (ø) Carriedforward from 0efa671
neon_talk 99.45% <ø> (ø) Carriedforward from 0efa671
nextcloud 24.33% <ø> (ø) Carriedforward from 0efa671
notifications_app 97.40% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 0efa671
talk_app 98.93% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../packages/talk_app/lib/src/blocs/message_bloc.dart 100.00% <100.00%> (ø)
...ork/packages/talk_app/lib/src/widgets/message.dart 98.79% <100.00%> (-0.01%) ⬇️

@provokateurin provokateurin merged commit c8b2857 into main Nov 1, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/talk_app/reference-resolving branch November 1, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

References are not always displayed on the first render of the chat message widget
2 participants