Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamite): Escape wireNames #2443

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

provokateurin
Copy link
Member

New field in Nextcloud 30 starts with a $

Signed-off-by: provokateurin <[email protected]>
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 27.20%. Comparing base (81606fa) to head (5915c57).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...mite_end_to_end_test/lib/interfaces.openapi.g.dart 18.75% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   27.21%   27.20%   -0.01%     
==========================================
  Files         370      369       -1     
  Lines      136663   136676      +13     
==========================================
+ Hits        37188    37189       +1     
- Misses      99475    99487      +12     
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 100.00% <ø> (ø) Carriedforward from 81606fa
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø)
dynamite_end_to_end_test 61.69% <18.75%> (-0.15%) ⬇️
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 81606fa
neon_dashboard 96.05% <ø> (ø) Carriedforward from 81606fa
neon_framework 43.55% <ø> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 81606fa
neon_talk 99.45% <ø> (ø) Carriedforward from 81606fa
nextcloud 23.26% <ø> (+<0.01%) ⬆️
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 81606fa
talk_app 99.09% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...namite_end_to_end_test/lib/interfaces.openapi.dart 41.17% <ø> (ø)
...mite_end_to_end_test/lib/interfaces.openapi.g.dart 29.35% <18.75%> (-2.61%) ⬇️

@provokateurin provokateurin merged commit 6bd4293 into main Aug 30, 2024
9 of 10 checks passed
@provokateurin provokateurin deleted the fix/dynamite/escape-wire-names branch August 30, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants