Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce drop-account capability #1213

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Oct 9, 2023

This change introduces the drop-account capability required by nextcloud/android#11950. The corresponding server-side plug-in change is documented here.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #1213 (26c1139) into master (475f478) will decrease coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is 16.66%.

❗ Current head 26c1139 differs from pull request most recent head 9c7ffe3. Consider uploading reports for the commit 9c7ffe3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1213      +/-   ##
============================================
- Coverage     52.51%   52.46%   -0.05%     
+ Complexity      973      972       -1     
============================================
  Files           189      189              
  Lines          6970     6976       +6     
  Branches        914      916       +2     
============================================
  Hits           3660     3660              
- Misses         2802     2806       +4     
- Partials        508      510       +2     
Files Coverage Δ
...cloud/android/lib/resources/status/OCCapability.kt 93.54% <100.00%> (+0.10%) ⬆️
...sources/status/GetCapabilitiesRemoteOperation.java 51.29% <0.00%> (-0.85%) ⬇️

... and 3 files with indirect coverage changes

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

tobiasKaminsky
tobiasKaminsky previously approved these changes Oct 24, 2023
@ZetaTom ZetaTom force-pushed the account-deletion-capability branch from 3b4bb8c to 096f130 Compare November 7, 2023 08:07
@ZetaTom ZetaTom force-pushed the account-deletion-capability branch from 096f130 to fb6295b Compare November 7, 2023 08:12
@AndyScherzinger AndyScherzinger force-pushed the account-deletion-capability branch from fb6295b to 26c1139 Compare November 7, 2023 10:56
tobiasKaminsky
tobiasKaminsky previously approved these changes Nov 8, 2023
@tobiasKaminsky
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the account-deletion-capability branch from 9c7ffe3 to 318e8db Compare November 9, 2023 08:42
ZetaTom and others added 2 commits November 9, 2023 10:11
Signed-off-by: tobiasKaminsky <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the account-deletion-capability branch from 318e8db to 5252638 Compare November 9, 2023 09:11
@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky merged commit 07800c2 into master Nov 14, 2023
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the account-deletion-capability branch November 14, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants