Merge pull request #36 from newrelic/log-oracle-home

Add log message if oracle home is unset

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.1.4 - 2019-03-19
+### Added
+- Log error message if ORACLE_HOME is unset
+
 ## 1.1.3 - 2019-02-04
 ### Fixed
 - Use correct protocol version

oracledb-config.yml.sample

@@ -16,6 +16,8 @@ instances:
       password: password
       # True if the monitoring user is a SysDBA. If omitted, defaults to false.
       is_sys_dba: true
+      # The location of ORACLE_HOME
+      oracle_home: /u01/app/oracle/product/version/database
       # True if the monitoring user is a SysOper. If omitted, defaults to false.
       is_sys_oper: false
       # A JSON array of tablespaces to collect. If omitted, collects all tablespaces.

src/oracledb.go

@@ -28,7 +28,7 @@ type argumentList struct {
 
 const (
 	integrationName    = "com.newrelic.oracledb"
-	integrationVersion = "1.1.3"
+	integrationVersion = "1.1.4"
 )
 
 var (
@@ -41,6 +41,11 @@ func main() {
 	i, err := integration.New(integrationName, integrationVersion, integration.Args(&args))
 	exitOnErr(err)
 
+	if oracleHome := os.Getenv("ORACLE_HOME"); oracleHome == "" {
+		log.Error("Required argument oracle_home is unset")
+		os.Exit(1)
+	}
+
 	// parse tablespace whitelist
 	err = parseTablespaceWhitelist()
 	exitOnErr(err)