-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[super-agent] [FB] chore!: remove default sub-agent #1533
base: master
Are you sure you want to change the base?
Conversation
chart_values: | ||
global: | ||
licenseKey: ${nr-env:NR_LICENSE_KEY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merging still waiting for:
Remove nrdot by default when installing AC chart
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if i understand the comment, but probably is because i just pushed the changes we discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing version bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i'm leaving this until we have a relase of AC with the changes
[ ] Guided install have been released with nrdot as default @josemore I do not think this is a blocker since we are pinning the chart version in the UI |
What this PR does / why we need it:
Special notes for your reviewer:
Look at checklist before merge!!!
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]