Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[super-agent] [FB] chore!: remove default sub-agent #1533

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gsanchezgavier
Copy link
Contributor

@gsanchezgavier gsanchezgavier commented Nov 20, 2024

What this PR does / why we need it:

  • Adds rbac to handle secrets
  • Remove default sub-agent
  • Simplify rbac

Special notes for your reviewer:

Look at checklist before merge!!!

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Guided install have been released with nrdot as default @josemore
  • AC has been released and updated in this PR with the latest nrdot agent type
  • Chart Version bumped

chart_values:
global:
licenseKey: ${nr-env:NR_LICENSE_KEY}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merging still waiting for:

Remove nrdot by default when installing AC chart

right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if i understand the comment, but probably is because i just pushed the changes we discussed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing version bump

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i'm leaving this until we have a relase of AC with the changes

@gsanchezgavier gsanchezgavier changed the title [super-agent] [FB] chore: remove deprecated nrdot defaults [super-agent] [FB] chore!: remove default sub-agent Nov 20, 2024
@paologallinaharbur
Copy link
Member

[ ] Guided install have been released with nrdot as default @josemore

I do not think this is a blocker since we are pinning the chart version in the UI
https://source.datanerd.us/nr1-dev-experience/shared-component-framework-configs/blob/c7cfed93c19fc1a7131d01d2d663f77fde6bbb7d/shared-component/configs/data-sources/super-agent/config.yml#L973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants