chore: Additional valid location for THIRD_PARTY_NOTICES #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `third-party-notices-exist` rule to allow the `THIRD_PARTH_NOTICES` file to exist either in root of the repo or in a `Licenses` folder. This is to mitigate false-positive reports when running RepoLinter on the .NET Agent repo, which maintains `Licenses/THIRD_PARTY_NOTICES.txt` (sample: newrelic/newrelic-dotnet-agent#1706)
|
I have no problem with this and I have tagged legal team, just alerting them of this change. If there is a problem, I'll flip it back but for right now I approve. |
CliftonDobrich
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
third-party-notices-existrule to allow theTHIRD_PARTH_NOTICESfile to exist either in root of the repo or in aLicensesfolder.This is to mitigate false-positive reports when running RepoLinter on the .NET Agent repo, which maintains
Licenses/THIRD_PARTY_NOTICES.txt