forked from danse-inelastic/histogram
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Logger/C++ Debug Mechanism Addition and Journal removal #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #6 +/- ##
==========================================
- Coverage 76.97% 76.96% -0.02%
==========================================
Files 42 42
Lines 3175 3173 -2
==========================================
- Hits 2444 2442 -2
Misses 731 731 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…gger configurations in src and tests, logger info and debug in tests
mpatrou
changed the title
Python Logger/C++ Debug Addition and Journal removal
Python Logger/C++ Debug Mechanism Addition and Journal removal
Nov 18, 2024
Tested locally both python and c++ part. Both works with new python logging. Please make sure to squash and merge. |
KyleQianliMa
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
Python logger mechanism added, journal removed and other cleanup changes
Long description of the changes:
The code include the following changes:
The PR enables python logging with various levels:
pytest --log-cli-level=DEBUG
also the building process of C libraries and python are found and attached in the testing section.
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
python part only:
cmake installation python and /C:
Print various logging levels in pytest:
References
[Story] [Histogram] Replace Journal with python logging module