Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ldap_cert_file mentions #189

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Remove ldap_cert_file mentions #189

merged 1 commit into from
Nov 7, 2024

Conversation

delozierjk
Copy link
Contributor

Description of the changes

Check all that apply:

  • [x ] updated documentation
  • [ x] Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (7dc0e6b) to head (d29659c).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #189   +/-   ##
=======================================
  Coverage   77.52%   77.53%           
=======================================
  Files          54       54           
  Lines        4704     4701    -3     
=======================================
- Hits         3647     3645    -2     
+ Misses       1057     1056    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glass-ships glass-ships merged commit 6dae8e1 into next Nov 7, 2024
4 checks passed
@glass-ships glass-ships deleted the 6313_remove_ldap_refs branch November 7, 2024 15:21
@glass-ships glass-ships changed the title Remove ldap mentions Remove ldap_cert_file mentions Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants