Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acquiring status for before data is ready #182

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Sep 19, 2024

Description of the changes

6375: [WebMon] Separate run status "acquiring" from status "incomplete" in WebMon

This uses the existing is_acquisition_complete method to determine the new status. It works by looking for the POSTPROCESS.DATA_READY message for that run to know that the acquisition has finished.

To test yourself you can run the system tests then view the run list pages. Run 100 should show error (file doesn't exist) while 101 should still be "acquiring"

http://localhost/dasmon/summary/

2024-09-19-153500_640x377_scrot

http://localhost/dasmon/arcs/runs/

2024-09-19-153508_660x253_scrot

http://localhost/report/arcs/experiment/IPTS-11111/

2024-09-19-153516_663x193_scrot

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.25%. Comparing base (154c713) to head (2d9ea38).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #182   +/-   ##
=======================================
  Coverage   77.24%   77.25%           
=======================================
  Files          50       50           
  Lines        4632     4633    +1     
=======================================
+ Hits         3578     3579    +1     
  Misses       1054     1054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari
Copy link
Contributor

Separating out run status "acquiring" is a welcome change. Good idea to use the message POSTPROCESS.DATA_READY to check whether the run is done acquiring data.

I tested locally and after running the system tests I can see the run with status "acquiring" on http://localhost/dasmon/summary/:
image

We can also filter by status to only see the runs that are acquiring:

image

Looks great 👌✨

@rosswhitfield rosswhitfield merged commit 6077aad into next Sep 20, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the acquiring_status branch September 20, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants