Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the last workflow RunStatus that a autoreducer node has sent #181

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Sep 16, 2024

Description of the changes

Ref: 6756: [WebMon] Show autoreducer last non-heartbeat message on diagnostics page

This will now show in addition to the heartbeat the last workflow status message sent by the autoreducer nodes.

2024-09-16-152702_610x141_scrot

If when this goes into production it is slow we can add a new table that just has the Parameter for the autoreducer node and the last RunStaus that it sent, which should be a small table compared to the Information table. But at the moment it doesn't seem like an issue.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.24%. Comparing base (17de271) to head (2118ee0).
Report is 1 commits behind head on next.

Files with missing lines Patch % Lines
src/webmon_app/reporting/dasmon/view_util.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #181      +/-   ##
==========================================
+ Coverage   77.10%   77.24%   +0.13%     
==========================================
  Files          50       50              
  Lines        4626     4632       +6     
==========================================
+ Hits         3567     3578      +11     
+ Misses       1059     1054       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosswhitfield rosswhitfield force-pushed the autoreducer_last_message branch from c83aa23 to caae959 Compare September 16, 2024 06:15
@backmari
Copy link
Contributor

backmari commented Sep 16, 2024

Sorry for this nitpicking, and not sure why it looks different in my browser, but could you please change the table layout so only the column with the message gets wrapped, but the hostname and time stamp are unwrapped (maybe they can have fixed width)?
Screenshot from 2024-09-16 11-38-54
Apart from that, looks good! 👌

@rosswhitfield
Copy link
Member Author

Sorry for this nitpicking, and not sure why it looks different in my browser, but could you please change the table layout so only the column with the message gets wrapped, but the hostname and time stamp are unwrapped (maybe they can have fixed width)? Screenshot from 2024-09-16 11-38-54 Apart from that, looks good! 👌

No problem, I set no-wrap on those cells.

@backmari
Copy link
Contributor

Thanks!
image

Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds useful diagnostics information for autoreduction. I have tested the change locally and the last workflow message for the autoreducer is shown as expected.

@rosswhitfield rosswhitfield merged commit 154c713 into next Sep 17, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the autoreducer_last_message branch September 17, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants