-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the last workflow RunStatus that a autoreducer node has sent #181
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #181 +/- ##
==========================================
+ Coverage 77.10% 77.24% +0.13%
==========================================
Files 50 50
Lines 4626 4632 +6
==========================================
+ Hits 3567 3578 +11
+ Misses 1059 1054 -5 ☔ View full report in Codecov by Sentry. |
c83aa23
to
caae959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds useful diagnostics information for autoreduction. I have tested the change locally and the last workflow message for the autoreducer is shown as expected.
Description of the changes
Ref: 6756: [WebMon] Show autoreducer last non-heartbeat message on diagnostics page
This will now show in addition to the heartbeat the last workflow status message sent by the autoreducer nodes.
If when this goes into production it is slow we can add a new table that just has the Parameter for the autoreducer node and the last RunStaus that it sent, which should be a small table compared to the Information table. But at the moment it doesn't seem like an issue.
Check all that apply:
References:
Manual test for the reviewer
(Instructions for testing here)
Check list for the reviewer