Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove catalog_process from the workflow graph #177

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Aug 28, 2024

Description of the changes

Fix a couple of typos and remove catalog_process from the workflow graph

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

Not needed

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@jmborr jmborr requested a review from backmari August 28, 2024 16:28
@jmborr jmborr self-assigned this Aug 28, 2024
jmborr added 5 commits August 28, 2024 12:43
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Replaced the AMQ and PV generator services with the unified webmonchow service. Updated Dockerfiles, Docker Compose, and documentation to reflect this change, simplifying the deployment and maintenance process.

Signed-off-by: Jose Borreguero <[email protected]>
Corrected spelling errors in documentation files for instrument addition and test fixtures. Updated the service dependency graph by removing redundant connections, improving clarity.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr force-pushed the erase_catalog_process branch from 74931c3 to 2c845cf Compare August 28, 2024 16:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (8409e9c) to head (2c845cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #177   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          50       50           
  Lines        4626     4626           
=======================================
  Hits         3567     3567           
  Misses       1059     1059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit da38a73 into next Aug 28, 2024
4 checks passed
@jmborr jmborr deleted the erase_catalog_process branch August 28, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants