Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ewm8373 rebin normalization and reduction output correctly #520

Draft
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

walshmm
Copy link
Collaborator

@walshmm walshmm commented Dec 12, 2024

Description of work

Explanation of work

To test

Dev testing

CIS testing

# replace with your test script below

Link to EWM item

EWM#<ticket_number>

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

  • acceptance criterion 1
  • acceptance criterion 2

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 31.00000% with 69 lines in your changes missing coverage. Please review.

Project coverage is 48.44%. Comparing base (80ea2e0) to head (5129d7d).
Report is 2 commits behind head on next.

Files with missing lines Patch % Lines
...red/backend/recipe/RebinFocussedGroupDataRecipe.py 41.30% 27 Missing ⚠️
...d/backend/recipe/GenerateFocussedVanadiumRecipe.py 23.80% 16 Missing ⚠️
src/snapred/backend/recipe/ReductionRecipe.py 0.00% 7 Missing ⚠️
src/snapred/backend/service/ReductionService.py 30.00% 7 Missing ⚠️
...snapred/backend/recipe/ApplyNormalizationRecipe.py 25.00% 6 Missing ⚠️
src/snapred/backend/recipe/Recipe.py 0.00% 5 Missing ⚠️
src/snapred/meta/mantid/WorkspaceNameGenerator.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             next     #520       +/-   ##
===========================================
- Coverage   95.61%   48.44%   -47.17%     
===========================================
  Files          67       68        +1     
  Lines        5012     5076       +64     
===========================================
- Hits         4792     2459     -2333     
- Misses        220     2617     +2397     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant