Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix att selection #125

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix att selection #125

merged 3 commits into from
Jul 16, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Jul 16, 2024

Fix the attenuator selection for the scaling factor calculation.
The attenuator column was not passed to the calculation.

@mdoucet mdoucet requested a review from jmborr July 16, 2024 13:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (51fe80b) to head (b3e0428).

Files Patch % Lines
RefRed/sf_calculator/reduction_sf_calculator.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #125      +/-   ##
==========================================
- Coverage   60.53%   60.52%   -0.01%     
==========================================
  Files         121      121              
  Lines       10125    10129       +4     
==========================================
+ Hits         6129     6131       +2     
- Misses       3996     3998       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit 5cced0e into next Jul 16, 2024
3 checks passed
@jmborr jmborr deleted the fix_Att branch July 16, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants