Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check all tests pass #121

Merged
merged 5 commits into from
Apr 27, 2024
Merged

check all tests pass #121

merged 5 commits into from
Apr 27, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Apr 27, 2024

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

jmborr and others added 5 commits April 27, 2024 16:44
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.13%. Comparing base (57cdd67) to head (47efb48).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #121      +/-   ##
==========================================
- Coverage   60.18%   60.13%   -0.06%     
==========================================
  Files         119      119              
  Lines       10137    10124      -13     
==========================================
- Hits         6101     6088      -13     
  Misses       4036     4036              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit afa1750 into next Apr 27, 2024
3 checks passed
@jmborr jmborr deleted the check_tests_pass branch April 27, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants