-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common entry-widget for MainGui and SFCalculatorUI #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmborr
changed the title
create deadtime entry widget
Common entry-widget for MainGui and SFCalculatorUI
Apr 27, 2024
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
options for the main GUI Signed-off-by: Jose Borreguero <[email protected]>
unit tests for DeadTimeEntryPoint Signed-off-by: Jose Borreguero <[email protected]>
unit tests for SFCalculator.apply_deadtime_update Signed-off-by: Jose Borreguero <[email protected]>
unit tests for SFCalculator.show_dead_time_dialog Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #120 +/- ##
==========================================
+ Coverage 60.13% 60.35% +0.21%
==========================================
Files 119 120 +1
Lines 10124 10157 +33
==========================================
+ Hits 6088 6130 +42
+ Misses 4036 4027 -9 ☔ View full report in Codecov by Sentry. |
…dtime_settings Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
mdoucet
approved these changes
Apr 27, 2024
mdoucet
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References Task 4953 [REFRED] Common entry-widget for MainGui and SFCalculatorUI
Manual test for the reviewer
Before running the manual tests, install the conda environment and install the source in editable mode
Start RefRed GUI
Or run tests
(refred-dev)> pytest test/unit/RefRed/test_main.py
Check list for the reviewer