Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common entry-widget for MainGui and SFCalculatorUI #120

Merged
merged 16 commits into from
Apr 28, 2024
Merged

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Apr 27, 2024

References Task 4953 [REFRED] Common entry-widget for MainGui and SFCalculatorUI

Manual test for the reviewer

Before running the manual tests, install the conda environment and install the source in editable mode

> conda env create --solver libmamba --name refred-dev --file ./environment.yml
> conda activate refred-dev
(refred-dev)> pip install -e .

Start RefRed GUI

(refred-dev)> PYTHONPATH=$(pwd):$PYTHONPATH ./scripts/start_refred.py

Or run tests

(refred-dev)> pytest test/unit/RefRed/test_main.py

Check list for the reviewer

  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@jmborr jmborr changed the title create deadtime entry widget Common entry-widget for MainGui and SFCalculatorUI Apr 27, 2024
@neutrons neutrons deleted a comment from codecov-commenter Apr 27, 2024
@neutrons neutrons deleted a comment from codecov-commenter Apr 27, 2024
jmborr added 14 commits April 27, 2024 17:49
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
 options for the main GUI

Signed-off-by: Jose Borreguero <[email protected]>
 unit tests for DeadTimeEntryPoint

Signed-off-by: Jose Borreguero <[email protected]>
 unit tests for SFCalculator.apply_deadtime_update

Signed-off-by: Jose Borreguero <[email protected]>
 unit tests for SFCalculator.show_dead_time_dialog

Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.35%. Comparing base (afa1750) to head (05a7d19).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #120      +/-   ##
==========================================
+ Coverage   60.13%   60.35%   +0.21%     
==========================================
  Files         119      120       +1     
  Lines       10124    10157      +33     
==========================================
+ Hits         6088     6130      +42     
+ Misses       4036     4027       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr requested a review from mdoucet April 28, 2024 00:36
@jmborr jmborr merged commit b1e4ae1 into next Apr 28, 2024
3 checks passed
@jmborr jmborr deleted the deadtime_entry branch April 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants