Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event weights in weighted reflectivity calculation #52

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Dec 5, 2024

One option for normalization when computing R is to assign a weight to each event according to the flux spectrum. This allows to bin easily in Q, Qx-Qz, etc.. The implementation didn't account for the recent addition of the dead time correction.
This PR fixes that.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.31%. Comparing base (b664256) to head (4ba6c18).
Report is 23 commits behind head on next.

Files with missing lines Patch % Lines
reduction/lr_reduction/event_reduction.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #52      +/-   ##
==========================================
- Coverage   83.87%   83.31%   -0.57%     
==========================================
  Files          20       20              
  Lines        2431     2451      +20     
==========================================
+ Hits         2039     2042       +3     
- Misses        392      409      +17     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet merged commit 74af5cd into next Dec 5, 2024
1 check passed
@mdoucet mdoucet deleted the fix-weights branch December 5, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants