Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix q-summing for up/down reflection #51

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Fix q-summing for up/down reflection #51

merged 5 commits into from
Dec 4, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Dec 3, 2024

The way we compute the q offset according to counts in pixels in y needs to account for whether we reflect up or down. This PR fixes that.

For a correct calculation, we also need the reflected peak's true center, not just the center of the range.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (b664256) to head (8f850aa).
Report is 9 commits behind head on next.

Files with missing lines Patch % Lines
reduction/lr_reduction/event_reduction.py 16.66% 10 Missing ⚠️
reduction/lr_reduction/template.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #51      +/-   ##
==========================================
- Coverage   83.87%   83.41%   -0.46%     
==========================================
  Files          20       20              
  Lines        2431     2448      +17     
==========================================
+ Hits         2039     2042       +3     
- Misses        392      406      +14     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet requested a review from backmari December 3, 2024 20:30
@mdoucet mdoucet merged commit 0a51128 into next Dec 4, 2024
1 check passed
@mdoucet mdoucet deleted the q_summing branch December 4, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants