Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to calc emission delay #43

Merged
merged 5 commits into from
Sep 6, 2024
Merged

add option to calc emission delay #43

merged 5 commits into from
Sep 6, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Sep 5, 2024

Add option to compute emission delay instead of using effective distance.

@mdoucet mdoucet requested a review from backmari September 5, 2024 18:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 69.84127% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.16%. Comparing base (f7d3627) to head (5097619).
Report is 8 commits behind head on next.

Files with missing lines Patch % Lines
reduction/lr_reduction/event_reduction.py 66.66% 12 Missing ⚠️
reduction/lr_reduction/template.py 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #43      +/-   ##
==========================================
- Coverage   82.20%   82.16%   -0.05%     
==========================================
  Files          20       20              
  Lines        2327     2394      +67     
==========================================
+ Hits         1913     1967      +54     
- Misses        414      427      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mdoucet mdoucet merged commit e6a4bf2 into next Sep 6, 2024
1 check passed
@mdoucet mdoucet deleted the emission_delay branch September 6, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants