Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation should conform to that of the python-project template #37

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Jul 29, 2024

EWM 6302

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@jmborr jmborr self-assigned this Jul 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@569ac33). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #37   +/-   ##
=======================================
  Coverage        ?   82.36%           
=======================================
  Files           ?       20           
  Lines           ?     2280           
  Branches        ?        0           
=======================================
  Hits            ?     1878           
  Misses          ?      402           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jmborr added 3 commits July 29, 2024 15:57
@jmborr jmborr merged commit 534137b into next Jul 29, 2024
1 check passed
@jmborr jmborr deleted the introduce_docs branch July 29, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants