Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better dead time correction #30

Merged
merged 4 commits into from
May 1, 2024
Merged

Implement better dead time correction #30

merged 4 commits into from
May 1, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented May 1, 2024

Add better dead time correction.

The new correction applies a weight to each event upon loading so that the workflow doesn't have to change.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.80%. Comparing base (fe4e351) to head (bac745e).

Files Patch % Lines
reduction/lr_reduction/event_reduction.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   82.91%   82.80%   -0.11%     
==========================================
  Files          20       20              
  Lines        2265     2257       -8     
==========================================
- Hits         1878     1869       -9     
- Misses        387      388       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet requested a review from jmborr May 1, 2024 18:00
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@mdoucet mdoucet merged commit 788720f into master May 1, 2024
1 check passed
@mdoucet mdoucet deleted the better_dt branch May 1, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants