Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dead time to scaling factors #26

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Add dead time to scaling factors #26

merged 5 commits into from
Apr 8, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Apr 1, 2024

Most of the Liquids Reflectometer code is now in this repo, except for the scaling factor calculation.
This PR brings those Mantid algorithms back to this repo. It keeps them as Mantid algorithm because it provide a nice way to encapsulate the work.

The two algorithms that were added were modified to use the dead time correction. A small workflow function as added to help orchestrate the calculation with a simple call, which can be added to RefRed.

Tests were added to exercise the various options and increase coverage.

  • Add SF algorithms
  • Ensure all the dead time algorithm parameters are propagated
  • Write a top level workflow that can easily be called by other applications to run SF calculations
  • Write tests
  • Modify autoreduction script to use new SF workflow

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (32ef089) to head (62f2596).

Files Patch % Lines
...n/lr_reduction/scaling_factors/LRDirectBeamSort.py 78.04% 45 Missing ⚠️
...n/lr_reduction/scaling_factors/LRScalingFactors.py 91.76% 21 Missing ⚠️
reduction/test/test_scaling_factors.py 97.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   79.23%   81.38%   +2.14%     
==========================================
  Files          16       20       +4     
  Lines        1695     2256     +561     
==========================================
+ Hits         1343     1836     +493     
- Misses        352      420      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet self-assigned this Apr 2, 2024
@mdoucet mdoucet requested a review from jmborr April 2, 2024 16:11
@mdoucet mdoucet requested a review from jmborr April 8, 2024 16:43
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very fancy 🌸

@mdoucet mdoucet merged commit 8f0d896 into master Apr 8, 2024
1 check passed
@mdoucet mdoucet deleted the sf_dt branch April 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants