Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dead time #23

Merged
merged 15 commits into from
Mar 8, 2024
Merged

Fixed dead time #23

merged 15 commits into from
Mar 8, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Mar 7, 2024 •
edited
Loading

Short description of the changes:

Add dead time correction

@mdoucet mdoucet changed the title Fixed deat time Fixed dead time Mar 7, 2024
jmborr
jmborr requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to run linters and static analysis tools on this repo.

reduction/lr_reduction/event_reduction.py Outdated Show resolved Hide resolved
reduction/lr_reduction/DeadTimeCorrection.py Outdated Show resolved Hide resolved
reduction/lr_reduction/DeadTimeCorrection.py Outdated Show resolved Hide resolved
reduction/lr_reduction/DeadTimeCorrection.py Outdated Show resolved Hide resolved
reduction/lr_reduction/DeadTimeCorrection.py Show resolved Hide resolved
reduction/lr_reduction/event_reduction.py Show resolved Hide resolved
reduction/lr_reduction/event_reduction.py Show resolved Hide resolved
reduction/lr_reduction/event_reduction.py Show resolved Hide resolved
reduction/lr_reduction/template.py Outdated Show resolved Hide resolved
reduction/lr_reduction/workflow.py Outdated Show resolved Hide resolved
@mdoucet mdoucet requested a review from jmborr March 8, 2024 14:32
jmborr
jmborr approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to leave the resolution of calling the algorithm from mantid.simpleapi for later

@mdoucet mdoucet merged commit 800eb04 into master Mar 8, 2024
1 check passed
@mdoucet mdoucet deleted the fixed_deat_time branch March 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmborr jmborr jmborr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdoucet @jmborr