Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two backgrounds option #19

Merged
merged 18 commits into from
Feb 19, 2024
Merged

Add Two backgrounds option #19

merged 18 commits into from
Feb 19, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Feb 16, 2024

Short description of the changes:

Include an option for the reflectivity data to use one or two background ranges

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr self-assigned this Feb 16, 2024
@jmborr jmborr requested a review from mdoucet February 16, 2024 19:17
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr
Copy link
Member Author

jmborr commented Feb 19, 2024

@mdoucet I'm going to fix the couple of tests that are still failing, then I'll let you know with another request for your review/approval.

@jmborr jmborr merged commit 46fc00b into master Feb 19, 2024
1 check passed
@mdoucet mdoucet deleted the two_backgrounds branch December 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants