Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace macro ITERATE_REMOVE by functions #3263

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Replace macro ITERATE_REMOVE by functions #3263

merged 9 commits into from
Dec 3, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Dec 2, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.07792% with 60 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (6dfdc4a) to head (da121cd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnoc/seclist.cpp 22.07% 60 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files         571      571              
  Lines      111096   111113      +17     
==========================================
+ Hits        74521    74531      +10     
- Misses      36575    36582       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azure-pipelines Azure Pipelines
Copy link

✔️ 814dd33 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ af6e029 -> Azure artifacts URL

JCGoran
JCGoran approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments.

src/nrnoc/seclist.cpp Outdated Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ cce8fc9 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alkino alkino enabled auto-merge (squash) December 3, 2024 15:35
@azure-pipelines Azure Pipelines
Copy link

✔️ da121cd -> Azure artifacts URL

@alkino alkino merged commit d24a901 into master Dec 3, 2024
36 checks passed
@alkino alkino deleted the cornu/iterate_remove_to_function branch December 3, 2024 16:12
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #239782 (:no_entry:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCGoran JCGoran JCGoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @JCGoran