Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::queue to simplify a complex loop #3261

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use std::queue to simplify a complex loop #3261

wants to merge 5 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Dec 2, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (d24a901) to head (06f7a64).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3261      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files         571      571              
  Lines      111113   111110       -3     
==========================================
- Hits        74531    74528       -3     
  Misses      36582    36582

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azure-pipelines Azure Pipelines
Copy link

✔️ 0a52b1b -> Azure artifacts URL

@azure-pipelines Azure Pipelines
Copy link

✔️ c797c39 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino enabled auto-merge (squash) December 3, 2024 07:31
@alkino alkino disabled auto-merge December 3, 2024 07:31
@alkino alkino enabled auto-merge (squash) December 3, 2024 07:31
1uc
1uc reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of using (essentially) two pointers into the list to keep track of which sections haven't had their children inserted yet is nicer than using this additional queue.

src/nrnoc/seclist.cpp Show resolved Hide resolved
@alkino
Copy link
Member Author

alkino commented Dec 3, 2024

So you prefer to keep the previous algorithm?

@1uc
Copy link
Collaborator

1uc commented Dec 3, 2024

My impression is that the proposed implementation is nicer, but the previous algorithm is more elegant.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 06f7a64 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #239806 (:no_entry:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @1uc