-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Py2NRNString
.
#3249
base: master
Are you sure you want to change the base?
Refactor Py2NRNString
.
#3249
Conversation
✔️ 9d6872b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
9d6872b
to
c6523a2
Compare
✔️ c6523a2 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
c6523a2
to
fe213e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3249 +/- ##
==========================================
- Coverage 67.08% 67.07% -0.01%
==========================================
Files 571 571
Lines 111092 111052 -40
==========================================
- Hits 74523 74487 -36
+ Misses 36569 36565 -4 ☔ View full report in Codecov by Sentry. |
✔️ fe213e8 -> Azure artifacts URL |
Quality Gate passedIssues Measures |
The
Py2NRNString
consisted of (what's now) aunique_cstr
. The ctor would create the cstr, and{g,s}et_pyerr
were non-static methods. They needed to check if the cstr as anullptr
, but where only ever called after checking that it was anullptr
.This commit separates several notions:
unique_cstr
.as_ascii
.{g,s}et_pyerr
were made static an are independent of each other and from converting a Python object to an (ASCII) C-string.PyErr2NRNString
was removed.