Better assertion in Python utils

[JCGoran]

It's a bit challenging to debug any potential failures in the Python tests if the failure is not asserted at the exact location, so it's better to fail early rather than propagating an error flag further.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[1uc]

I agree with the motivation, but I'm not sure I see why this moves the assert close enough to where the issue occurs to make a difference. The pattern is still:

expect = ...
actual = ...

assert expected == actual, f"..."

where actual was computed some time in the past; and the assert happens some time later.

One difference that might be unintended is that now an array of value does cause printing information for each entry. Rather it'll print something for the first value and then crash.

[azure-pipelines]

✔️ 01feeb1 -> Azure artifacts URL

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.17%. Comparing base (cd7ac7d) to head (01feeb1).

Files with missing lines	Patch %	Lines
share/lib/python/neuron/tests/utils/checkresult.py	71.42%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3149   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files         573      573           
  Lines      111439   111433    -6     
=======================================
- Hits        74856    74855    -1     
+ Misses      36583    36578    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bbpbuildbot]

Logfiles from GitLab pipeline #237102 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[pramodk]

One difference that might be unintended is that now an array of value does cause printing information for each entry. Rather it'll print something for the first value and then crash.

It would be good to take care of this.