Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit.ci actions fail: check-manifest and ensurepip error #67

Closed
lauraporta opened this issue Jul 3, 2023 · 1 comment · Fixed by #68
Closed

Pre-commit.ci actions fail: check-manifest and ensurepip error #67

lauraporta opened this issue Jul 3, 2023 · 1 comment · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@lauraporta
Copy link
Member

Describe the bug
I am testing the new version of the cookiecutter in the package rsp_vision and I have spotted a bug in the newly introduced hook for check_manifest.
pre-commit run --all-files and check-manifest alone run with no problems locally and on Actions, but pre-commit.ci fail.

To Reproduce
I added the new modifications via cruft. Follow our tutorial for more details.

Expected behaviour
I expected pre-commit.ci to give me the same output of pre-commit and check-manifest.

Log file

check docstring is first.................................................Passed
check that executables have shebangs.................(no files to check)Skipped
check for merge conflicts................................................Passed
check toml...............................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
fix requirements.txt.................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
ruff.....................................................................Passed
black....................................................................Passed
mypy.....................................................................Passed
check-manifest...........................................................Failed
- hook id: check-manifest
- exit code: 2

['/pc/clone/TAKS1oo8Q1iJjs2ocS4O2A/py_env-python3/bin/python', '-m', 'build', '--sdist', '.', '--outdir', '/tmp/check-manifest-tafqwydp-sdist'] failed (status 1):
* Creating venv isolated environment...
ERROR Failed to create venv. Maybe try installing virtualenv.
  Command '/tmp/build-env-tewll_oj/bin/python3.11 -m ensurepip --upgrade --default-pip' failed with return code 1
  stdout:
    /tmp/build-env-tewll_oj/bin/python3.11: No module named ensurepip

Is this the same of #59 ?

Possible Solution
ensurepip does not need to be installed, it is part of the standard library I think.

However I cannot see where the installation of ensurepip is specified. Not sure how to solve this

@lauraporta lauraporta added the bug Something isn't working label Jul 3, 2023
@lauraporta lauraporta self-assigned this Jul 3, 2023
@lauraporta
Copy link
Member Author

I have found a discussion on this same bug 👉🏻 in the original repo from which check-manifest hook was cloned from

@lauraporta lauraporta linked a pull request Jul 3, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant