Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _from_valid_data public #223

Closed
vigji opened this issue Jun 14, 2024 · 2 comments
Closed

Make _from_valid_data public #223

vigji opened this issue Jun 14, 2024 · 2 comments
Labels
enhancement New optional feature

Comments

@vigji
Copy link
Collaborator

vigji commented Jun 14, 2024

Is your feature request related to a problem? Please describe.

I would like to create valid datasets from the output of custom pipelines and not from file.

Describe the solution you'd like
I would simply make the movement.io._from_valid_data public - or add a public interface to it. Sorry if there's already one and I missed it!

@vigji vigji added the enhancement New optional feature label Jun 14, 2024
@niksirbi
Copy link
Member

Hey @vigji, we recently added a public from_numpy() function, I think this should cover your use-case?

You can try updating to the latest movement version to use that.

See our rationale in #194

@vigji
Copy link
Collaborator Author

vigji commented Jun 14, 2024

Oh amazing exactly what I was looking for, thanks :)

@vigji vigji closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature
Projects
None yet
Development

No branches or pull requests

2 participants