This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Fix docker upload bugs #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dhuangnm
commented
Jul 1, 2024
dhuangnm
commented
- Fixed a bug due to output whl and build version value missing
- Renamed input argument wheel to whl to be consistent across actions and jobs
- Removed unnecessary part in Dockerfile that caused image build to fail due to permission issue
dhuangnm
requested review from
dbarbuzzi,
andy-neuma,
derekk-nm and
robertgshaw2-neuralmagic
derekk-nm
reviewed
Jul 2, 2024
derekk-nm
reviewed
Jul 2, 2024
derekk-nm
approved these changes
Jul 3, 2024
mgoin
suggested changes
Jul 3, 2024
mgoin
approved these changes
Jul 3, 2024
Thanks Michael! |
added 2 commits
July 3, 2024 14:45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.