Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Enable Release build for nightly/release workflow #338

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Enable Release build for nightly/release workflow #338

merged 4 commits into from
Jun 28, 2024

Conversation

dhuangnm
Copy link
Member

No description provided.

@robertgshaw2-neuralmagic
Copy link
Collaborator

I thought the plan here was to build in release mode rather than stripping after the fact?

@dhuangnm
Copy link
Member Author

I thought the plan here was to build in release mode rather than stripping after the fact?

Yes we can also enable release build but normally it's a good practice to strip the binaries for formal release. I can also take a look how to enable the release build.

Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully the build env works

.github/actions/nm-build-vllm/action.yml Outdated Show resolved Hide resolved
@dhuangnm
Copy link
Member Author

dhuangnm commented Jun 26, 2024

hopefully the build env works

Yeah it looks working from the build log: https://github.com/neuralmagic/nm-vllm/actions/runs/9685984319/job/26727409601

-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Build type: Release
-- Target device: cuda

Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dhuangnm dhuangnm changed the title strip all .so for the wheel Enable Release build for nightly/release workflow Jun 26, 2024
@dhuangnm dhuangnm merged commit f96cf9d into main Jun 28, 2024
28 checks passed
@dhuangnm dhuangnm deleted the stripwhl branch June 28, 2024 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants