This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 10
Embed git commit hash into Python source #319
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
58d607b
Embed git commit hash into Python source
dbarbuzzi 7197a97
Merge branch 'main' into simple-githash-embed
dbarbuzzi 4be63e0
Rename variable to `__commit__`
dbarbuzzi 2bc7f3b
Add simple presence test
dbarbuzzi ed5a4fd
Fix formatting
dbarbuzzi 246544d
Put a minimum length on commit test
dbarbuzzi cc05a07
Fix typo
dbarbuzzi 56824a1
Merge branch 'main' into simple-githash-embed
dbarbuzzi d732f35
Embed hash in setup.py
dbarbuzzi 2fff30c
Merge branch 'main' into simple-githash-embed
dbarbuzzi dd3102c
Remove extraneous newline
dbarbuzzi c2d46ed
Get full hash
dbarbuzzi e63e8e4
Use obvious placeholder value
dbarbuzzi 0e7c4f6
Fix replacement
dbarbuzzi 97b1890
Merge branch 'main' into simple-githash-embed
dbarbuzzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import vllm | ||
|
||
|
||
def test_embedded_commit_defined(): | ||
assert len(vllm.__commit__) > 7 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
# UPSTREAM SYNC: take downstream | ||
__version__ = "0.5.1" | ||
__commit__ = "COMMIT_HASH_PLACEHOLDER" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I do think this is a bit long as a placeholder or dummy value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any suggestions for an appropriately short one? Maybe
COMMIT_PLACEHOLDER
, or is that still long?