Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spellcheck workflow #6

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Add spellcheck workflow #6

merged 3 commits into from
Jul 24, 2024

Conversation

dbarbuzzi
Copy link
Collaborator

SUMMARY:
This PR adds a spellcheck workflow with two steps powered by existing GitHub actions:

  • Step 1 runs codespell to look for common misspellings, similar to vLLM itself
  • Step 2 runs a full-fledged spellcheck powered by aspell

To get step 2 passing, a custom word list was created, and the README was edited.

TEST PLAN:
See checks available on this PR/in the repo’s “Actions” tab.

@dbarbuzzi dbarbuzzi self-assigned this Jul 24, 2024
Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbarbuzzi dbarbuzzi merged commit 3a7911a into main Jul 24, 2024
1 check passed
@dbarbuzzi dbarbuzzi deleted the add-spellcheck-workflow branch July 24, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants