Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zora drops strategies #303

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

neatonk
Copy link
Member

@neatonk neatonk commented Oct 1, 2022

See #256

@TimDaub
Copy link
Collaborator

TimDaub commented Oct 3, 2022

Overall looks very good and mergable. Just one minor thing is that I spontaneously changed the strategy transformer interface and so now messages isn't a required property anymore, check it here: 5b087b5

@neatonk
Copy link
Member Author

neatonk commented Oct 3, 2022

Overall looks very good and mergable. Just one minor thing is that I spontaneously changed the strategy transformer interface and so now messages isn't a required property anymore, check it here: 5b087b5

I've fixed the transformer interface. Might as well merge this when ready so it doesn't fall out of sync with the main branch. The missing zora-drops-get-tokenuri strategy can be added in another PR.

@neatonk neatonk marked this pull request as ready for review October 3, 2022 14:28
@neatonk neatonk changed the title WIP add zora drops strategies add zora drops strategies Oct 3, 2022
@TimDaub
Copy link
Collaborator

TimDaub commented Oct 3, 2022

ok I ran all tests locally and this seems to work

@TimDaub TimDaub merged commit ffe11f1 into neume-network:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants