-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strategy to track NFTs curated on present materials #256
Comments
Yet another way to do this would be to get the contract addresses from the present materials contract first and then get metadata for each contract. This approach could lead to a situation where the same contract is reached by multiple strategies—leading to multiple outputs with potentially differing results. |
yes. But we're open to use other data sources too. |
|
Yep. To be clear this only applies to the contracts curated on https://www.presentmaterial.xyz/ and not other songcamp projects. |
EDIT This comment is incorrect. See #256 (comment) Implementation notes:
|
Steps to add zora editions strategies:
Steps to include the zora editions strategies in the active crawl path.
|
I've looked into this and I think it sounds legit. https://etherscan.io/address/0x91A8713155758d410DFAc33a63E193AE3E89F909 This contract essentially emits the edition creation event and basically a different contract handles the edition to tokenId translation, right? |
EDIT This comment is incorrect. See #256 (comment)
Thanks
For whatever reason, the |
Getting started now on the steps described here: #256 (comment) |
awesome, looking forward |
@TimDaub Are non-audio NFTs filtered globally or per strategy? If not filtered, most NFTs produced by this strategy will be images. |
sound, catalog v2 and mintsongs only have music NFTs. And for zora, we filter by catalog v1 ids |
The details provided above were based on the wrong set of contracts. The following values should be used instead.
|
The
|
like this, right:
|
Yes, although I see that the ZoraNFTCreatorV1 contract has This can be addressed in the strategy by looking the tokenURI scheme to determine the message type. Or, it can be addressed in the extraction worker by adding a message type that can handle any URI. I'm leaning towards the latter as it a more generic solution. |
The For now, I think it is good enough to handle drops which use the EditionMetadataRenderer and ignore the rest. This is helpful because the uri scheme and metadata format are known and can be transformed to match the required schema. Also, this covers all editions created using the https://create.zora.co/create/edition interface and is sufficient to handle the present materials curated contracts. |
My comments adapted from discord:
call-block-logs
strategy. Since the zora drops contracts are deployed by a factory, they would be handled very much likesound
is currently.web3subgraph
I imagine, usingcall-block-logs
would be preferred.The text was updated successfully, but these errors were encountered: